menu button: Use proper focus api
authorMatthias Clasen <mclasen@redhat.com>
Sun, 9 Jun 2019 02:19:30 +0000 (02:19 +0000)
committerMatthias Clasen <mclasen@redhat.com>
Sun, 9 Jun 2019 17:38:54 +0000 (17:38 +0000)
Widgets are supposed to call gtk_widget_child_focus.
Calling internal focus_move function directly makes
us skip the childs ::focus() implementation, which
is where the magic happens.

gtk/gtkmenubutton.c

index 7937982a776b9a86f0b99c80645531e96e437fa3..c4813ebbc7480aa15c6740a454e33ec4dd5cba37 100644 (file)
@@ -521,9 +521,9 @@ gtk_menu_button_focus (GtkWidget        *widget,
   GtkMenuButtonPrivate *priv = gtk_menu_button_get_instance_private (button);
 
   if (priv->menu && gtk_widget_get_visible (priv->menu))
-    return gtk_widget_focus_move (priv->menu, direction);
+    return gtk_widget_child_focus (priv->menu, direction);
   else if (priv->popover && gtk_widget_get_visible (priv->popover))
-    return gtk_widget_focus_move (priv->popover, direction);
+    return gtk_widget_child_focus (priv->popover, direction);
   else
     return GTK_WIDGET_CLASS (gtk_menu_button_parent_class)->focus (widget, direction);
 }